Skip to content

Use correct class to indicate present deprecation#8665

Merged
kevin-brown merged 2 commits intoencode:masterfrom
DavidCain:dcain-pending-depr-warning
Sep 22, 2022
Merged

Use correct class to indicate present deprecation#8665
kevin-brown merged 2 commits intoencode:masterfrom
DavidCain:dcain-pending-depr-warning

Conversation

@DavidCain
Copy link
Contributor

PendingDeprecationWarning means "we plan to deprecate, but haven't yet." A feature that's to be deleted in the next release is not planned to be deprecated; it is deprecated.

Base class for warnings about features which are obsolete and expected
to be deprecated in the future, but are not deprecated at the moment.

This class is rarely used as emitting a warning about a possible
upcoming deprecation is unusual, and DeprecationWarning is preferred for
already active deprecations.

(emphasis mine)

https://docs.python.org/3/library/exceptions.html#PendingDeprecationWarning

`PendingDeprecationWarning` means "we plan to deprecate, but haven't
yet." A feature that's to be deleted in the next release is not planned
to be deprecated; it **is** deprecated.

> Base class for warnings about features which are obsolete and expected
> to be deprecated in the future, but are not deprecated at the moment.
>
> This class is rarely used as emitting a warning about a possible
> upcoming deprecation is unusual, and DeprecationWarning is preferred for
> already active deprecations.

https://docs.python.org/3/library/exceptions.html#PendingDeprecationWarning
@kevin-brown kevin-brown merged commit 2de5081 into encode:master Sep 22, 2022
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
`PendingDeprecationWarning` means "we plan to deprecate, but haven't
yet." A feature that's to be deleted in the next release is not planned
to be deprecated; it **is** deprecated.

> Base class for warnings about features which are obsolete and expected
> to be deprecated in the future, but are not deprecated at the moment.
>
> This class is rarely used as emitting a warning about a possible
> upcoming deprecation is unusual, and DeprecationWarning is preferred for
> already active deprecations.

https://docs.python.org/3/library/exceptions.html#PendingDeprecationWarning

Co-authored-by: Tom Christie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants