Fix error in throttling when request.user is None#8370
Merged
lovelydinosaur merged 1 commit intoencode:masterfrom Jun 24, 2022
Merged
Fix error in throttling when request.user is None#8370lovelydinosaur merged 1 commit intoencode:masterfrom
lovelydinosaur merged 1 commit intoencode:masterfrom
Conversation
Check to see if request.user is set before proceeding with further authentication checks.
AliRn76
approved these changes
Mar 5, 2022
|
This affects me as well. Is there a chance to merge that soon? |
|
+1 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Contributor
|
Normally you'd expect an |
sigvef
pushed a commit
to sigvef/django-rest-framework
that referenced
this pull request
Dec 3, 2022
Check to see if request.user is set before proceeding with further authentication checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to remove the Django authentication module, I've ran into an error when using the configuration below.
Specifically, an
AttributeErroris raised because DRF does not expect the user to beNone.This PR fixes the issue by checking if
request.useris set before proceeding with further authentication checks.The test suite and pre-commit hooks are passing. If needed, I'll be happy to write a test-case for this.
As this is my first contribution to DRF please let me know in case I am missing any contribution guidelines. I'd like for the process to be as seamless as possible.
Thank you for your time and consideration.