Conversation
adamchainz
commented
Apr 5, 2021
adamchainz
commented
- Recreate all the jobs on GitHub Actions
- Upgrade to Ubuntu 20.04
- Upgrade base/docs/dist to Python 3.9
* Recreate all the jobs on GitHub Actions * Upgrade to Ubuntu 20.04 * Upgrade base/docs/dist to Python 3.9
| [testenv:py37-django32] | ||
| ignore_errors = true | ||
|
|
||
| [testenv:py38-django32] |
There was a problem hiding this comment.
Should we be allowing test failures on 3.2? It's due this week?
There was a problem hiding this comment.
Just copying what's there already - I think there's a process to update things when the release comes out.
|
Alright we are green! ✅ |
carltongibson
left a comment
carltongibson
left a comment
There was a problem hiding this comment.
Yay! Thanks for this @adamchainz ⛵️
(What is this Python setup that doesn't have wheel? 🤔😀)
|
This is fantastic, thanks Adam! It's worth comparing and contrasting with our HTTPX workflow, here... https://github.com/encode/httpx/blob/master/.github/workflows/test-suite.yml I'm pretty keen on the style in the HTTPX approach of GitHub's scripts to rule them all pattern, together with one-liner steps. Also different there is that we don't currently use caching, and if we did, we'd introduce it in a follow-up commit, to help us review the UI difference that it introduces, so we can better understand where it fits in, and be in a better position to assess if something changes/breaks there. Having said both of those things I'm completely fine with you taking a lead on this @adamchainz - we can either...
For myself, I'mma approve this, and then leave that in your court. |
|
I'm personally not that sold on the "scripts for everything" approach. I think it removes some of the power of the CI environment, such as caching, running pre-commit in parallel through its action, etc. Would be happy to convert django-rest-framework to that pattern in a follow-up though if it's really desired. |
The config I copied in encode#7903 was from a repo with the new name 'main', so tests have not been running on master since.
The config I copied in #7903 was from a repo with the new name 'main', so tests have not been running on master since.
* Recreate all the jobs on GitHub Actions * Upgrade to Ubuntu 20.04 * Upgrade base/docs/dist to Python 3.9
The config I copied in encode#7903 was from a repo with the new name 'main', so tests have not been running on master since.
4 participants
