rework Field.__init__ to use either kwargs / class attrs.#2469
Closed
dnozay wants to merge 1 commit intoencode:masterfrom
Closed
rework Field.__init__ to use either kwargs / class attrs.#2469dnozay wants to merge 1 commit intoencode:masterfrom
dnozay wants to merge 1 commit intoencode:masterfrom
Conversation
Precedence is given to kwargs over class attributes. You can create a subclass of a Field for 99% of your use cases while still needing a one-off instance where you need to change an attribute; hence kwargs is still useful. Other important point is that kwargs is the current de-facto standard for declaring fields in a serializer. Conflicts: rest_framework/fields.py
This was referenced Jan 26, 2015
Contributor
|
Main objection to this approach would be that we'd lose exceptions when a developer misspells an argument or otherwise includes an invalid keyword argument to a field. |
Contributor
|
Let's drop this one given that it would lose exceptions on misspelt arguments, which'd make it easier to introduce trivial errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Precedence is given to kwargs over class attributes.
You can create a subclass of a Field for 99% of your use cases while still
needing a one-off instance where you need to change an attribute; hence
kwargs is still useful.
Other important point is that kwargs is the current de-facto standard for
declaring fields in a serializer.
Conflicts:
rest_framework/fields.py