Hide passwords in repo path, fixing #58#66
Conversation
|
Thanks for the contribution! As the regex only applies to REST paths, I would move the regex replacement code into an The regex also won't match rest paths of the form |
|
You're right, i didn't think about ports, will have to check. But you're right i'm missing quite a few test cases. Thin i was focusing on here wasmainly that we can have the protocol optional in the URL (diallowing the URL() from js). |
|
I actually tried to design it to work with any URL, rest but also sftp, ftps or any future URL like path. Ports and the whole path after the domain are now more leniently handled. Care to have a look? |
|
Looks good to me. Thanks! |
No description provided.