Support read-only repositories by using --no-lock.#145
Merged
emuell merged 2 commits intoemuell:masterfrom Apr 14, 2025
Merged
Conversation
emuell
reviewed
Apr 14, 2025
Owner
emuell
left a comment
emuell
left a comment
There was a problem hiding this comment.
I think that deserves a comment. Else this looks good to me.
Maybe something like:
// all expected restic operations are read-only right now, so always avoid locks
args.push(Cow::Borrowed(OsStr::new("--no-lock")));
?
Contributor
Author
|
Good point! I've updated it. Thanks for the fast response and for your amazing software! 😊 |
Owner
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added the
--no-lockflag and everything seemed to work.Thins I've tested:
All of this seemed to work fine.
Related issue #144