Added dockerfiles form trzeci/emscripten-docker#368
Added dockerfiles form trzeci/emscripten-docker#368sbc100 merged 11 commits intoemscripten-core:masterfrom
Conversation
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
I have lots of small nits but generally I think this I good thing and we should include it here.
If you'd like to address some of these issues after the initial commit I'd be OK with that too.
trzecieu
force-pushed
the
ppp/dockerfiles
branch
from
942eb5e to
855558e
Compare
trzecieu
force-pushed
the
ppp/dockerfiles
branch
from
519d7b8 to
24d6ee6
Compare
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
This is looking good to me now. @kripken how about you?
Can we add this under https://hub.docker.com/u/emscripten? Perhaps as "emsdk"?
|
No comments from me, looks reasonable, thanks! Would it be possible to test this? (as in, test that building this Docker image leads to a working environment?) Sounds good to add to docker hub. Let me know your usernames there and I'll add you. |
|
I'm sbc100 on docker hub |
|
I'm |
trzecieu
force-pushed
the
ppp/dockerfiles
branch
from
deae2e1 to
9a0bd72
Compare
|
Ok, added you two and a team and a repo, hopefully I've done it all correctly, let me know! |
3 participants
As a continuation from: emscripten-core/emscripten#8742
This PR provides adopted Dockerfile from https://github.com/trzecieu/emscripten-docker/blob/master/docker/trzeci/emscripten-fastcomp/Dockerfile which supports builds:
Features:
1000:1000useremscriptenI understand that some of used solutions might not meet expectations, hence I'm open for suggestions how to improve it.
CC: @kripken @sbc100