Replace musl seek syscall with wasi fd_seek #9555
Conversation
|
I ran into a problem here, SDL assumes the values of Possible fix for SDL in emscripten-ports/SDL2#96 but I'm not sure yet if this is a real bug, or if SDL will want such a fix. Another option is for us to convert between them in our libc. That adds a little work and code size which is unfortunate, so I'd like to avoid that. @sunfishcode is there a reason the wasi constants don't match existing conventions? |
…as compatible with ours; after this change, it no longer is
|
This PR also noticed that the llvm_nativizer tool, which worked only on fastcomp, stopped working. That tool basically just took LLVM IR for asm.js and compiled it natively, relying on libcs being compatible enough, which this PR breaks. As this tool is fastcomp-only and not really anything reliable, I just removed it. |
src/library_syscall.js
Outdated
| // lacks the attribute to set the import module and base names) and | ||
| // in LTO mode (as bitcode does not preserve them). | ||
|
|
||
| if (!WASM_BACKEND || !WASM_OBJECT_FILES) { |
There was a problem hiding this comment.
This might be a side question or one for @sbc100 but do you know if (WASM_BACKEND && !WASM_OBJECT_FILES) uses the emscripten driver code to do the bitcode linking, or the one in clang/lld? IIUC the upstream backend bitcode does preserve the prefixing, because how else would the attribute propagate from clang to the backend? I guess I just don't understand why (WASM_BACKEND && !WASM_OBJECT_FILES) doesn't work here.
There was a problem hiding this comment.
This is a bug in wasm-ld where linking with -r/--relocatable doesn't preserve these attributes. I'm working on a fix at the moment.
|
As there is agreement to change the wasi constants, I made this PR use the fixed-up values, which are identical to the old musl and SDL ones. |
Update wasi to use the new whence constants, see WebAssembly/WASI#106
No description provided.