ldso: loadedDynamicLibraries is not used anymore - kill it#7517
Merged
kripken merged 1 commit intoemscripten-core:incomingfrom Nov 20, 2018
Merged
ldso: loadedDynamicLibraries is not used anymore - kill it#7517kripken merged 1 commit intoemscripten-core:incomingfrom
kripken merged 1 commit intoemscripten-core:incomingfrom
Conversation
This variable stoped being used after d6e54c2 (simplify shared library initialization: use the system atprerun/atinit logic, except when the system is already loaded as in the dlopen case).
Contributor
Author
|
( spawned from #7512 ) |
Member
|
Thanks @navytux, looks good! Have you already added yourself to AUTHORS? If not please do so before we merge this. |
Contributor
Author
Member
|
I see, thanks! |
Contributor
Author
|
Thanks for applying the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This variable stoped being used after d6e54c2 (simplify shared library
initialization: use the system atprerun/atinit logic, except when the
system is already loaded as in the dlopen case).