More consistent UMD exports and then() support#6477
Closed
curiousdannii wants to merge 1 commit intoemscripten-core:incomingfrom
Closed
More consistent UMD exports and then() support#6477curiousdannii wants to merge 1 commit intoemscripten-core:incomingfrom
curiousdannii wants to merge 1 commit intoemscripten-core:incomingfrom
Conversation
…#5864) Also provide .then() when in MODULARIZE_INSTANCE mode (emscripten-core#6442)
Member
|
Thanks! Looks good. Let's just add testing for the new features here. In particular I'm curious to see how testing the |
Contributor
Author
|
Do we have any existing tests for then()? |
Member
|
Looks like |
|
This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 7 days. Feel free to re-open at any time if this issue is still relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do a full UMD export when not in MODULARIZE mode (fix #5864)
Also provide .then() when in MODULARIZE_INSTANCE mode (#6442)