I've just noticed in some code I'm using that it appears that stdout isn't flushed when I call exit? It would be good to flush stdout and stderr when we call the atexit handlers.

@NWilson that sounds like something we should do. FS.quit is called during exit, and it calls close() on the streams. @juj , perhaps we should call flush from there?

@juj Do you know if we have tests for this? If not we should add one.

When the streams close, they do flush, but the problem is that if no exit runtime is set, exit won't be called, and the streams won't close, and therefore won't flush either. @NWilson: do you have a test case that fails?

I've updated the pull request with a test case from #2770.

Good point about noExitRuntime, I often use that so that's probably what
was causing the lack of flushing for me. I'll take back my comment now I
can't produce a test case!

Nicholas Wilson: [email protected]
Site and blog: www.nicholaswilson.me.uk
29 Beales Way, CB4 2PW
07845 182898

On 18 November 2014 13:51, juj [email protected] wrote:

When the streams close, they do flush, but the problem is that if no exit
runtime is set, the streams won't flush. @NWilson
https://github.com/NWilson: do you have a test case that fails?

I've updated the pull request with a test case from #2770
#2770.

—
Reply to this email directly or view it on GitHub
#2771 (comment).

Is this ready for review?

Yes, this is good to go.