Automatically convert returned pointers to unsigned in CAN_ADDRESS_GB mode.#19755
Merged
Automatically convert returned pointers to unsigned in CAN_ADDRESS_GB mode.#19755
Conversation
sbc100
changed the title
…ode. When we have a signature for native function and we know it returns a pointer we automatically interpret it as unsigned when it arrives in JS.
sbc100
force-pushed
the
convert_returned_pointers
branch
from
99d46d6 to
e62bc66
Compare
Collaborator
Author
|
Even though there were only two places where I was actually able to remove the explicit Line 3550 in cd3596b |
kripken
approved these changes
Jun 29, 2023
sbc100
added a commit
that referenced
this pull request
Jun 30, 2023
Also, remove explicit coercion of result of _sbrk() call. As of #19755 this happens automatically.
sbc100
added a commit
that referenced
this pull request
Jun 30, 2023
Also, remove explicit coercion of result of _sbrk() call. As of #19755 this happens automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we have a signature for native function and we know it returns a pointer we automatically interpret it as unsigned when it arrives in JS.