fix: avoid repeating same result in __randname on passing same template pointer #18914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Mar 7, 2023
|
|
||
| __clock_gettime(CLOCK_REALTIME, &ts); | ||
| r = ts.tv_nsec*65537 ^ (uintptr_t)&ts / 16 + (uintptr_t)template; | ||
| r = ts.tv_nsec*65537 ^ (uintptr_t)&ts / 16 + (uintptr_t)template + seed++; |
Collaborator
There was a problem hiding this comment.
Can you mark with /* XXX EMSCRIPTEN ... */ and maybe try to keep the changes isolated from the original code. How about:
/* XXX EMSCRIPTEN: avoid repeating the same result when __clock_gettime does not change between calls. */
static unsigned int seed = 0;
r += seed++;
Contributor
Author
There was a problem hiding this comment.
understood, updating it
sbc100
approved these changes
Mar 7, 2023
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
Can you give a better title to this PR. Perhaps "Avoid repeating the same result in __randname"?
debadree25
changed the title
Contributor
Author
|
update the code and title, does it look ok? |
sbc100
reviewed
Mar 7, 2023
|
|
||
| /* XXX EMSCRIPTEN: avoid repeating the same result when __clock_gettime does not change between calls. */ | ||
| static unsigned int seed = 0; | ||
| r += seed++; |
Collaborator
There was a problem hiding this comment.
Is seed the right name for this? How about increment or counter?
Contributor
Author
There was a problem hiding this comment.
updated, counter looks good
This was referenced Mar 8, 2023
impact-maker
pushed a commit
to impact-maker/emscripten
that referenced
this pull request
Mar 17, 2023
impact-maker
pushed a commit
to impact-maker/emscripten
that referenced
this pull request
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempted to fix the issue of the same pointer possibly causing the same random path to be returned by adding a static variable to keep count, I am unsure how I could add a test for this 😅
Fixes: #18591