Conversation
- Use `elif` here so its clear that we either include one block or the next, but never both. - Fix signature of setjmp. - Include the `_emscripten_throw_longjmp` stub regardless of `INCLUDE_FULL_LIBRARY` settings. This final fix is a prerequisite for #16003.
kripken
approved these changes
Dec 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
elifhere so its clear that we either include one block or the next, but never both._emscripten_throw_longjmpstub regardless ofINCLUDE_FULL_LIBRARYsettings.This final fix is a prerequisite for #16003. Without this change LLD_REPORT_UNDEFINED results in the following different error message: