Switch from addAtMain to addAtInit in library_fs.js #14306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
May 26, 2021
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Other than that comment, I think this looks good.
It may be good to document that permissions are ignored during preRun, but not after. Perhaps this:
diff --git a/src/library_fs.js b/src/library_fs.js
index 62aedb89e..91e20c6f8 100644
--- a/src/library_fs.js
+++ b/src/library_fs.js
@@ -97,8 +97,9 @@ FS.staticInit();` +
initialized: false,
// Whether we are currently ignoring permissions. Useful when preparing the
// filesystem and creating files inside read-only folders.
- // This is set to false when the runtime is initialized, allowing you
- // to modify the filesystem freely before run() is called.
+ // This is set to false during the "Init" phase, which means that you can
+ // modify the filesystem freely during "PreRun" using Module.preRun for
+ // example.
ignorePermissions: true,
trackingDelegate: {},
tracking: {
kripken
approved these changes
May 26, 2021
Using addAtMain stopped working for programs without main functions (HAS_MAIN not defined) after #13901. Code that needs to populate the FS is mostly likely going to be run during preRun callback which all happen before ATINITs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using addAtMain stopped working for programs without main functions
(HAS_MAIN not defined) after #13901.
Code that needs to populate the FS is mostly likely going to be run
during preRun callback which all happen before ATINITs.