Skip to content

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Apr 15, 2021

Fixes: #13791

@sbc100 sbc100 requested a review from kripken April 15, 2021 05:11
@sbc100 sbc100 force-pushed the atmain branch 2 times, most recently from a968063 to f666167 Compare April 15, 2021 05:14
@sbc100 sbc100 changed the title Don't run ATMAINS unless there is _main function exported Don't include ATMAINS unless there is _main function exported Apr 15, 2021
@sbc100 sbc100 merged commit 6e794e6 into main Apr 15, 2021
@sbc100 sbc100 deleted the atmain branch April 15, 2021 18:50
sbc100 added a commit that referenced this pull request May 26, 2021
Using addAtMain stopped working for programs without main functions
(HAS_MAIN not defined) after #13901.

Code that needs to populate the FS is mostly likely going to be run
during preRun callback which all happen before ATINITs.
sbc100 added a commit that referenced this pull request May 26, 2021
Using addAtMain stopped working for programs without main functions
(HAS_MAIN not defined) after #13901.

Code that needs to populate the FS is mostly likely going to be run
during preRun callback which all happen before ATINITs.
sbc100 added a commit that referenced this pull request May 26, 2021
Using addAtMain stopped working for programs without main functions
(HAS_MAIN not defined) after #13901.

Code that needs to populate the FS is mostly likely going to be run
during preRun callback which all happen before ATINITs.
sbc100 added a commit that referenced this pull request May 27, 2021
Using addAtMain stopped working for programs without main functions
(HAS_MAIN not defined) after #13901.

Code that needs to populate the FS is mostly likely going to be run
during preRun callback which all happen before ATINITs.
sbc100 added a commit that referenced this pull request Jul 2, 2021
This reduces code size and prevents accidental/confusing use of these
elements, which don't have any meaning without a main function.

Since #13901 they have been in-active in application without a main
export.

Might help with #14583.
sbc100 added a commit that referenced this pull request Jul 7, 2021
Support for `addAtMain` in application without a main function was
removed in #13901 but I missed that fact that webidl_binder.py was doing
this.

This change replaces `addAtMain` with `addOnInit` and also makes the use
of `addAtMain` in applications withoiut a `main` into an error so that
the problem (and solution) should be clear.

Update webidl binder test to only use sync compilation when needed, so
that code in question actually gets tested.

This change also reduces code size by not including `addAtMain` at all
in applcications without a `main`.

Fixes: #14583.
sbc100 added a commit that referenced this pull request Jul 7, 2021
Support for `addAtMain` in application without a main function was
removed in #13901 but I missed that fact that webidl_binder.py was doing
this.

This change replaces `addAtMain` with `addOnInit` and also makes the use
of `addAtMain` in applications withoiut a `main` into an error so that
the problem (and solution) should be clear.

Update webidl binder test to only use sync compilation when needed, so
that code in question actually gets tested.

This change also reduces code size by not including `addAtMain` at all
in applcications without a `main`.

Fixes: #14583.
sbc100 added a commit that referenced this pull request Jul 13, 2021
Support for `addAtMain` in application without a main function was
removed in #13901 but I missed that fact that webidl_binder.py was doing
this.

This change replaces `addAtMain` with `addOnInit` and also makes the use
of `addAtMain` in applications without a `main` into an error so that
the problem (and solution) should be clear.

Update webidl binder test to only use sync compilation when needed, so
that code in question actually gets tested.

This change also reduces code size by not including `addAtMain` at all
in applications without a `main`.

Fixes: #14583.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MINIMAL_RUNTIME and no main() causes error on compilation

3 participants