-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Don't include ATMAINS unless there is _main function exported #13901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a968063 to
f666167
Compare
kripken
reviewed
Apr 15, 2021
kripken
approved these changes
Apr 15, 2021
sbc100
added a commit
that referenced
this pull request
May 26, 2021
Using addAtMain stopped working for programs without main functions (HAS_MAIN not defined) after #13901. Code that needs to populate the FS is mostly likely going to be run during preRun callback which all happen before ATINITs.
sbc100
added a commit
that referenced
this pull request
May 26, 2021
Using addAtMain stopped working for programs without main functions (HAS_MAIN not defined) after #13901. Code that needs to populate the FS is mostly likely going to be run during preRun callback which all happen before ATINITs.
sbc100
added a commit
that referenced
this pull request
May 26, 2021
Using addAtMain stopped working for programs without main functions (HAS_MAIN not defined) after #13901. Code that needs to populate the FS is mostly likely going to be run during preRun callback which all happen before ATINITs.
sbc100
added a commit
that referenced
this pull request
May 27, 2021
Using addAtMain stopped working for programs without main functions (HAS_MAIN not defined) after #13901. Code that needs to populate the FS is mostly likely going to be run during preRun callback which all happen before ATINITs.
sbc100
added a commit
that referenced
this pull request
Jul 7, 2021
Support for `addAtMain` in application without a main function was removed in #13901 but I missed that fact that webidl_binder.py was doing this. This change replaces `addAtMain` with `addOnInit` and also makes the use of `addAtMain` in applications withoiut a `main` into an error so that the problem (and solution) should be clear. Update webidl binder test to only use sync compilation when needed, so that code in question actually gets tested. This change also reduces code size by not including `addAtMain` at all in applcications without a `main`. Fixes: #14583.
sbc100
added a commit
that referenced
this pull request
Jul 7, 2021
Support for `addAtMain` in application without a main function was removed in #13901 but I missed that fact that webidl_binder.py was doing this. This change replaces `addAtMain` with `addOnInit` and also makes the use of `addAtMain` in applications withoiut a `main` into an error so that the problem (and solution) should be clear. Update webidl binder test to only use sync compilation when needed, so that code in question actually gets tested. This change also reduces code size by not including `addAtMain` at all in applcications without a `main`. Fixes: #14583.
sbc100
added a commit
that referenced
this pull request
Jul 13, 2021
Support for `addAtMain` in application without a main function was removed in #13901 but I missed that fact that webidl_binder.py was doing this. This change replaces `addAtMain` with `addOnInit` and also makes the use of `addAtMain` in applications without a `main` into an error so that the problem (and solution) should be clear. Update webidl binder test to only use sync compilation when needed, so that code in question actually gets tested. This change also reduces code size by not including `addAtMain` at all in applications without a `main`. Fixes: #14583.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13791