Split standard_b64encode_impl #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowone
force-pushed
the
standard_b64encode_impl
branch
from
8bb35a3 to
ed31a89
Compare
Open
emmatyping
reviewed
Nov 18, 2025
youknowone
force-pushed
the
standard_b64encode_impl
branch
from
ed31a89 to
5d45c51
Compare
youknowone
commented
Nov 19, 2025
Modules/_base64/src/lib.rs
Outdated
| fn from_object(obj: &PyObject) -> Result<Self, ()> { | ||
| let mut view = MaybeUninit::<Py_buffer>::uninit(); | ||
| if unsafe { PyObject_GetBuffer(obj, view.as_mut_ptr(), PYBUF_SIMPLE) } != 0 { | ||
| if unsafe { PyObject_GetBuffer(obj as *const _ as *mut _, view.as_mut_ptr(), PYBUF_SIMPLE) } != 0 { |
Author
There was a problem hiding this comment.
Passing Rc::into_raw() is the right interface. But this patch doesn't include Rc
Author
There was a problem hiding this comment.
The new interface guarantees there is no mutating to PyObject on Rust side. mutating in C side is okay as before.
Owner
There was a problem hiding this comment.
I think you could expose .raw_get() from the inner UnsafeCell to get a *mut _object, but I guess that won't work as I assume PyObject_GetBuffer expects a *mut PyObject, right?
Author
There was a problem hiding this comment.
That's right. But the idea using .raw() and encapsulating it from PyObject is also a better idea.
Author
There was a problem hiding this comment.
I added PyObject::as_raw(). Please give it a better name.
emmatyping
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
standard_b64encode is inherently an unsafe function. Meanwhile, standard_b64encode_impl uses unsafe operations internally, but it is intended to be a function where the programmer guarantees its safety. By separating these two functions, we can ensure that the truly safe parts of standard_b64encode_impl remain outside the unsafe block.
BorrowedBuffer::from_object is actually safe as long as the pointer to the object remains valid. In this case, it seems better to require the caller to ensure pointer validity rather than hiding that requirement inside the function itself.