Add support for /dev/devices#311
Conversation
|
Thank you! I'm sorry for taking so long to notice and review this PR. This looks good, only a few comments:
The API you've added here looks good, but can you update the doc comment to say that the Also, these structs have |
|
I've fixed the items you pointed out. Please take a look! |
|
Thanks! Quick question: why is |
|
The difference in types is aligned with Linux kernel code. See below links. If you have a policy on whether to prioritize user convenience or align with the kernel regarding types, please let me know. https://github.com/torvalds/linux/blob/master/fs/char_dev.c#L36 |
|
Thanks for those links. My general policy is to prioritize alignment with the kernel (though I think I deviate from that in a few spots). A comment in the code with these links would be useful to anyone reading this code in the future, but that can happen later. Thanks for the pull request! |
Thank you for this amazing library! I found it incredibly useful. I implemented parser of /proc/devices and test.
Notes:
majorhas been same with the Linux kernel code.BlockDeviceEntrycan be disabled viaCONFIG_BLOCK, but it has not been made anOption.