feat: move PhysicalPageFlags to procfs-core#303
Merged
eminence merged 1 commit intoeminence:masterfrom Feb 17, 2024
tatref:PhysicalPageFlags-to-core
Merged
feat: move PhysicalPageFlags to procfs-core#303eminence merged 1 commit intoeminence:masterfrom tatref:PhysicalPageFlags-to-core
eminence merged 1 commit intoeminence:masterfrom
tatref:PhysicalPageFlags-to-core
Conversation
Owner
|
Regarding I need to review how procfs types are constructed in general, but I think we aren't very consistent. For example, I think several types should |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I needed to use
PhysicalPageFlagsfor a Windows project, so I moved it to procfs-coreI made
parse_infopubI removed the import of
CGroupControllerto remove a warningMaybe we could move
KPageFlagsalso, but we would need to also moveFileWrapperthat is part of procfs.What do you think?