Add MountInfos::iter#300
Merged
eminence merged 1 commit intoeminence:masterfrom Feb 3, 2024
rusty-snake:mountinfos-iter
Merged
Add MountInfos::iter#300eminence merged 1 commit intoeminence:masterfrom rusty-snake:mountinfos-iter
eminence merged 1 commit intoeminence:masterfrom
rusty-snake:mountinfos-iter
Conversation
This is a convenience for mountinfo.0.iter().
eminence
reviewed
Feb 3, 2024
|
|
||
| impl MountInfos { | ||
| /// Returns an borrowed iterator. | ||
| pub fn iter(&self) -> std::slice::Iter<'_, MountInfo> { |
Owner
There was a problem hiding this comment.
This is a minor point, but I wonder if we could do:
Suggested change
| pub fn iter(&self) -> std::slice::Iter<'_, MountInfo> { | |
| pub fn iter(&self) -> impl Iterator<Item = &MountInfo> { |
to hide the std::slice::Iter concrete type. In practice this doesn't matter much because the inner Vec is part of the public API of MountInfos (and so std::slice::Iter is kind of part of this API too)
Owner
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a convenience for
mountinfo.0.iter().