Add /proc/mounts#261
Merged
eminence merged 1 commit intoeminence:masterfrom May 10, 2023
tatref:mounts
Merged
Conversation
Owner
|
Thanks for all the PRs. I think I want to get #257 merged first, as I'm sure it'll conflict with other things. |
Contributor
Author
|
I rebased from master. A few changes compared to the first version:
What do you think? |
eminence
reviewed
May 10, 2023
procfs-core/src/mounts.rs
Outdated
| fn from_buf_read<R: BufRead>(r: R) -> ProcResult<Self> { | ||
| let mut vec = Vec::new(); | ||
|
|
||
| for line in r.lines().skip(1) { |
Contributor
Author
There was a problem hiding this comment.
I don't know what I did there... the file has no headers, so no reason to skip the first line
Owner
|
Also can you update |
Owner
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/proc/<pid>/mountsis the same format, so we could reuse some code