Don't hide process creation errors in all_processes#260
Merged
eminence merged 1 commit intoeminence:masterfrom May 10, 2023
tatref:process-iter-err
Merged
Don't hide process creation errors in all_processes#260eminence merged 1 commit intoeminence:masterfrom tatref:process-iter-err
eminence merged 1 commit intoeminence:masterfrom
tatref:process-iter-err
Conversation
Contributor
Author
|
I rebased from master |
Owner
|
Thanks, this change makes sense. As a followup TODO, some additional documentation about strategies to handle errors might be good (similar to the comment you made in the PR) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is followup of #188
Current implementation hide
Processcreation errors inall_processes, making this function nearly useless in a resource constrained environment. Errors are silently ignored, making look like only a few processes exist.The fact that FDs are created for each process is not necessarily an issue, but users of the library must have a way to know if any operation worked as expected or not.
This PR shouldn't change much for users, because the
Processesare wrapped in aResulteither wayExample usage