Refactor and expose memory map processing.#237
Merged
eminence merged 5 commits intoeminence:masterfrom Feb 1, 2023
Merged
Conversation
Owner
|
If you rebase onto the latest master branch, the CI issues will clear up (see #239) |
A new MemoryMaps struct is added, which parses all of `maps`, `smaps`, and `smaps_rollup`. Closes eminence#236.
afranchuk
force-pushed
the
expose-memory-map-parsing
branch
from
305ff7d to
1f74b8a
Compare
Contributor
Author
|
Looks good now! |
Contributor
Author
|
Hold up, forgot to add the permissions parsing (it could be a separate PR but there's probably no need). |
Contributor
Author
|
That should do it :) |
Contributor
Author
|
@eminence does this look good now? |
Owner
|
Sorry about the delay on my side. I'm going to take a look Very Soon Now™ |
eminence
reviewed
Feb 1, 2023
Owner
eminence
left a comment
eminence
left a comment
There was a problem hiding this comment.
LGTM, just a few comments. Thanks for working on this
afranchuk
force-pushed
the
expose-memory-map-parsing
branch
from
d725a7e to
489b7e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new MemoryMaps struct is added, which parses all of
maps,smaps, andsmaps_rollup.Closes #236.