ticks_per_second and page_size are infallible#235
Merged
Conversation
eminence
changed the title
These functions used to be fallible, but aren't any more. So they can directly return a u64, instead of a Result
eminence
force-pushed
the
no_panic_page_size
branch
from
1b74916 to
a07e679
Compare
eminence
added a commit
that referenced
this pull request
Jan 23, 2023
The page_size API changed in #235
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions used to be fallible, but aren't any more. So they can
directly return a u64, instead of a Result