Disabling default features on the chrono crate#210
Merged
eminence merged 1 commit intoeminence:masterfrom Nov 9, 2022
Merged
Conversation
Owner
|
Hi, sorry for the delay in sending a reply. Thanks for this PR. My understanding is that this change is fully semver compatible, since it's only removing features that |
Owner
|
This change still looks good to me, so I'm going ahead an merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Situation
The
chronocrate depends on an outdated version of thetimecrate, which has a known vulnerability.chronoapparently does not use the vulnerable element, but it has breaking backwards compatibility issues and will not be removed until they upgrade the major version. There is a workaround suggested in chronotope/chrono#602 (comment). I've compiled it myself and confirm the vulnerable crate no longer is a dependency inCargo.lock.Target
Remove the vulnerability to prevent vulnerability-tool noise.
Proposal
In accordance with the workaround, disable the default features of
chronoand instead replace it with the "clock" feature, which does not compile the vulnerable crate.