Process: Namespace: Use openat instead of building a path#192
Merged
eminence merged 3 commits intoeminence:masterfrom Aug 7, 2022
Merged
Process: Namespace: Use openat instead of building a path#192eminence merged 3 commits intoeminence:masterfrom
eminence merged 3 commits intoeminence:masterfrom
Conversation
eminence
requested changes
Aug 6, 2022
Owner
eminence
left a comment
eminence
left a comment
There was a problem hiding this comment.
LGTM, though please take a look at some of the suggestions I made. Thanks!
eminence
reviewed
Aug 6, 2022
Signed-off-by: Jon Doron <[email protected]>
Signed-off-by: Jon Doron <[email protected]>
This should resolve a case of a PID reuse Signed-off-by: Jon Doron <[email protected]>
Contributor
Author
|
Thank you for the review, I was thinking perhaps to add a derive Serialize/Deserialize to some of the public structs, does that sound ok to you? |
eminence
approved these changes
Aug 7, 2022
Owner
That sounds OK to me, but please put them behind a off-by-default feature flag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should resolve a case of a PID reuse
Signed-off-by: Jon Doron [email protected]