Conversation
Owner
Author
|
If you have time for a quick review @obaudys, I'd be grateful. |
obaudys
suggested changes
Jul 25, 2022
obaudys
left a comment
obaudys
left a comment
There was a problem hiding this comment.
Looks good to me; it neatly spells out what is going on and why.
You seem to have closed the impl block and then reopened it:
}
impl Process {
Is there any reason for that? Asking as a rust newbie.
Owner
Author
|
It's subtle, but I added some docs to the impl block on line 779. This isn't all that well known (and honestly not used that often), but you can add documentation to the impl block itself, as in: /// This is some docs
impl Foo {
/// Create a new thing
pub fn new() -> Self { todo!() }
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CC #188