Merged
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/8020-emilkbg-color View snapshot changes at kitdiff |
lucasmerlin
reviewed
Mar 25, 2026
Comment on lines
+266
to
+274
| for node in self.iter() { | ||
| let fill = node.frame().fill; | ||
| if fill.is_opaque() { | ||
| return fill; | ||
| } else if fill != Color32::TRANSPARENT { | ||
| total = fill.blend(total); | ||
| } | ||
| } | ||
| total |
Collaborator
There was a problem hiding this comment.
I think theres a bug here, if one if the parent layers is opaque, and the current one is semi transparent, we would disregard the transparent color and just return the opaque one without blending
Masterchef365
pushed a commit
to Masterchef365/egui
that referenced
this pull request
Apr 3, 2026
This lets you ask for the background color of a ui with `ui.stack().bg_color()`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets you ask for the background color of a ui with
ui.stack().bg_color()