Respect WidgetVisuals::expansion in TextEdit #8013
Merged
lucasmerlin merged 4 commits intomainfrom Mar 24, 2026
Merged
Conversation
The atom-based TextEdit conversion dropped the `visuals.expansion` that was previously applied via `response.rect.expand(expansion)`. Apply it the same way Button does: add expansion to inner_margin and use negative outer_margin so the painted frame expands outward.
|
Preview available at https://egui-pr-preview.github.io/pr/8013-lucasfix-atom-text-edit-size View snapshot changes at kitdiff |
lucasmerlin
changed the title
WidgetVisuals::expansion in atom-based TextEdit frameWidgetVisuals::expansion in TextEdit
emilk
approved these changes
Mar 24, 2026
Co-authored-by: Emil Ernerfeldt <[email protected]>
Masterchef365
pushed a commit
to Masterchef365/egui
that referenced
this pull request
Apr 3, 2026
This broke in emilk#7587 --------- Co-authored-by: Emil Ernerfeldt <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This broke in #7587