Add DebugOptions::warn_if_rect_changes_id#7984
Merged
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/7984-emilkwarn-on-id-change View snapshot changes at kitdiff |
This reverts commit 5bd1293.
aedm
approved these changes
Mar 18, 2026
Collaborator
aedm
left a comment
aedm
left a comment
There was a problem hiding this comment.
Thanks for taking care of this!
| // and the label changes on hover: | ||
| let is_hovered = ui.rect_contains_pointer(button_rect); | ||
| let label = if is_hovered { "Hovering!" } else { "Click me" }; | ||
| let id = ui.id().with(label); |
emilk
added a commit
that referenced
this pull request
Mar 21, 2026
* Found thanks to #7984 If you put an animated `Panel` inside a `Ui`, then the automatic ids for following widgets would differ when the panel was collapsed or open.
Masterchef365
pushed a commit
to Masterchef365/egui
that referenced
this pull request
Apr 3, 2026
If turned on (default in debug builds), if the exact same `Rect` exist in two subsequent frames but with different `Id`s, a warning is logged an a red rect is flashed on the screen.
Masterchef365
pushed a commit
to Masterchef365/egui
that referenced
this pull request
Apr 3, 2026
* Found thanks to emilk#7984 If you put an animated `Panel` inside a `Ui`, then the automatic ids for following widgets would differ when the panel was collapsed or open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If turned on (default in debug builds), if the exact same
Rectexist in two subsequent frames but with differentIds, a warning is logged an a red rect is flashed on the screen.