Update accesskit to 0.24.0 (and related deps)#7850
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/7850-accesskit-subtrees View snapshot changes at kitdiff |
|
@lucasmerlin @emilk friendly ping :) we’re starting to get blocked on this and rerun-io/kittest#18 in servo, so if there’s anything we can do to help land these soon it would be much appreciated! |
|
@delan could you please update accesskit to 0.24 and accesskit_winit to 0.32. We have updated windows-rs to 0.62 which should fix some of the CI errors here. |
|
done in 8ddc3d9, and in rerun-io/kittest@c95e1bc :) |
delan
force-pushed
the
accesskit-subtrees
branch
from
8ddc3d9 to
8eb50c2
Compare
This comment was marked as resolved.
This comment was marked as resolved.
delan
changed the title
We need to bump the accesskit version in order to use [subtrees](https://docs.rs/accesskit/latest/accesskit/struct.Node.html#method.tree_id), which are required to join the servo tree into the embedder tree. We need to patch egui for servoshell, as we're waiting for them to land the patch bumping their version of accesskit. Once emilk/egui#7850 lands and a new version of egui is pushed out, we'll be able to remove the patch. Testing: No tests. Fixes: Part of #4344 Signed-off-by: Alice Boxhall <[email protected]>
delan
force-pushed
the
accesskit-subtrees
branch
from
7d7a493 to
49dc444
Compare
|
We've just released accesskit_winit 0.32.2 which should help here. |
|
I was actually under the impression that rerun-io/kittest#22 would be needed first 🤔 |
delan
force-pushed
the
accesskit-subtrees
branch
2 times, most recently
from
c98a9f6 to
c20b515
Compare
thanks! i’ve patched it to the tip of your branch for now: e355a35 |
delan
force-pushed
the
accesskit-subtrees
branch
2 times, most recently
from
e355a35 to
8853e39
Compare
This comment was marked as resolved.
This comment was marked as resolved.
delan
force-pushed
the
accesskit-subtrees
branch
from
8853e39 to
0314b62
Compare
fractal clock snapshot test also fails identically on main for me, but it passes in CI, so i’ll ignore it. i’ve also updated deny.toml to ignore duplicate phf, since the old dependency is in two unrelated crates. |
delan
force-pushed
the
accesskit-subtrees
branch
from
9402363 to
146abed
Compare
Co-authored-by: Luke Warlow <[email protected]> Co-authored-by: lucasmerlin <[email protected]>
delan
force-pushed
the
accesskit-subtrees
branch
from
146abed to
4195619
Compare
|
Thanks for working on this, and sorry for the delay in getting this merged! |
|
@lucasmerlin @DataTriny thanks for landing these changes, and fixing the text selection code too! |
this patch updates our deps to [accesskit 0.24.0](https://docs.rs/accesskit/0.24.0/accesskit/) (was [0.21.1](https://docs.rs/accesskit/0.21.1/accesskit/)), [accesskit_consumer 0.35.0](https://docs.rs/accesskit_consumer/0.35.0/accesskit_consumer/) (was [0.30.1](https://docs.rs/accesskit_consumer/0.30.1/accesskit_consumer/)), and [accesskit_winit 0.32.0](https://docs.rs/accesskit_winit/0.32.0/accesskit_winit/) (was [0.29.1](https://docs.rs/accesskit_winit/0.29.1/accesskit_winit/)), allowing egui to be used in apps that use accessibility subtrees (AccessKit/accesskit#655). for now, we handle the subtree-related breaking changes by assuming that egui will use [the root tree](https://docs.rs/accesskit/0.24.0/accesskit/struct.TreeId.html#associatedconstant.ROOT), which is good enough for [servoshell](https://github.com/servo/servo) and does not require any API changes. * [x] I have followed the instructions in the PR template <img width="1185" height="954" alt="image" src="https://github.com/user-attachments/assets/6acfb85a-096d-4a7b-963b-d8549bfc749f" /> --------- Co-authored-by: Luke Warlow <[email protected]> Co-authored-by: lucasmerlin <[email protected]> Co-authored-by: Arnold Loubriat <[email protected]>
5 participants
this patch updates our deps to accesskit 0.24.0 (was 0.21.1), accesskit_consumer 0.35.0 (was 0.30.1), and accesskit_winit 0.32.0 (was 0.29.1), allowing egui to be used in apps that use accessibility subtrees (AccessKit/accesskit#655).
for now, we handle the subtree-related breaking changes by assuming that egui will use the root tree, which is good enough for servoshell and does not require any API changes.