Make FrameCache::get return a reference instead of cloning the cached value#7834
Merged
emilk merged 2 commits intoemilk:mainfrom Jan 11, 2026
Merged
Make FrameCache::get return a reference instead of cloning the cached value#7834emilk merged 2 commits intoemilk:mainfrom
FrameCache::get return a reference instead of cloning the cached value#7834emilk merged 2 commits intoemilk:mainfrom
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/7834-prframe-cache-get-ref View snapshot changes at kitdiff |
Masterchef365
pushed a commit
to Masterchef365/egui
that referenced
this pull request
Apr 3, 2026
…ed value (emilk#7834) This is a breaking change. - Enables using `FrameCache` in cases where the cached value cannot be cloned. - Improves use cases where only a reference to the cached value is needed. - If the user needs an owned value, they can clone it themselves. Adding a `get_ref` method instead of changing `get` would avoid the breaking change, but I didn't want to do so because it is kind of expected for `get` to return `&V` when querying a collection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change.
FrameCachein cases where the cached value cannot be cloned.Adding a
get_refmethod instead of changinggetwould avoid the breaking change, but I didn't want to do so because it is kind of expected forgetto return&Vwhen querying a collection.