Skip to content

plugin: export TypedPluginGuard and TypedPluginHandle#7780

Merged
lucasmerlin merged 1 commit intoemilk:mainfrom
apekros:apekros/plugin-mod
Jan 5, 2026
Merged

plugin: export TypedPluginGuard and TypedPluginHandle#7780
lucasmerlin merged 1 commit intoemilk:mainfrom
apekros:apekros/plugin-mod

Conversation

@apekros
Copy link
Copy Markdown
Contributor

@apekros apekros commented Dec 15, 2025

We have made this patch internally on our fork as we use TypedPluginGuard and TypedPluginHandle internally

  • I have followed the instructions in the PR template

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 15, 2025 •
edited
Loading

Preview available at https://egui-pr-preview.github.io/pr/7780-apekrosplugin-mod
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

View snapshot changes at kitdiff

emilk
emilk reviewed Dec 16, 2025
View reviewed changes
Copy link
Copy Markdown
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not put undocumented things into the top egui namespace.

Please add docstrings to these types, but then do pub mod plugin instead of re-exporting the types directly, to reduce the number of things the user can auto-complete to with egui::

@apekros
Copy link
Copy Markdown
Contributor Author

apekros commented Dec 20, 2025

Let's not put undocumented things into the top egui namespace.

Please add docstrings to these types, but then do pub mod plugin instead of re-exporting the types directly, to reduce the number of things the user can auto-complete to with egui::

Thanks for the prompt feedback, done! I have left the existing pub use for plugin::Plugin as I didn't think this was worth the breaking change

@apekros apekros requested a review from emilk December 20, 2025 07:52
@apekros apekros force-pushed the apekros/plugin-mod branch 2 times, most recently from 2b7a739 to 8ebaadb Compare December 20, 2025 09:08
@lucasmerlin lucasmerlin added feature New feature or request egui labels Jan 5, 2026
lucasmerlin
lucasmerlin approved these changes Jan 5, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@lucasmerlin lucasmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lucasmerlin lucasmerlin merged commit 457f8f4 into emilk:main Jan 5, 2026
26 of 27 checks passed
Masterchef365 pushed a commit to Masterchef365/egui that referenced this pull request Apr 3, 2026
@apekros @Masterchef365
plugin: export TypedPluginGuard and TypedPluginHandle (emilk#7780)
7aa25fd 
We have made this patch internally on our fork as we use
`TypedPluginGuard` and `TypedPluginHandle` internally

* [x] I have followed the instructions in the PR template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucasmerlin lucasmerlin lucasmerlin approved these changes

@emilk emilk Awaiting requested review from emilk

Assignees

No one assigned

Labels

egui feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@apekros @emilk @lucasmerlin