Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/7722-emilkscroll-area-margin View snapshot changes at kitdiff |
lucasmerlin
approved these changes
Nov 17, 2025
| let mut content_ui = ui.new_child( | ||
| UiBuilder::new() | ||
| .ui_stack_info(UiStackInfo::new(UiKind::ScrollArea)) | ||
| .max_rect(content_max_rect), |
Collaborator
There was a problem hiding this comment.
Can't we just do content_max_rect - content_margin here, to avoid the extra nested child Ui?
Owner
Author
There was a problem hiding this comment.
no, that affects inner_rect and so the scroll bars move…
Owner
Author
There was a problem hiding this comment.
Too much hassle. I'll leave it as a future optimization 😞
Masterchef365
pushed a commit
to Masterchef365/egui
that referenced
this pull request
Apr 3, 2026
* Part of emilk#5605 * Part of emilk#3385
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clip_rect_margin#5605