Fix debug-panic in ScrollArea if contents fit without scrolling#7440
Merged
emilk merged 2 commits intoemilk:mainfrom Aug 14, 2025
Merged
Fix debug-panic in ScrollArea if contents fit without scrolling#7440emilk merged 2 commits intoemilk:mainfrom
emilk merged 2 commits intoemilk:mainfrom
Conversation
If the ScrollArea's contents are smaller than the inner rect, but the scrollbar is set to always visible, clicking on it led to a remap from an empty range to calculate the new offset, which triggered a debug assertion in the remap function, because the result is indeterminate. Since in this case there is no need to scroll, we just skip the remap and set the offset to 0 directly.
|
Preview available at https://egui-pr-preview.github.io/pr/7440-fix-scrollbar-offset-empty-range |
emilk
reviewed
Aug 12, 2025
emilk
changed the title
emilk
pushed a commit
that referenced
this pull request
Aug 15, 2025
If the ScrollArea's contents are smaller than the inner rect, but the scrollbar is set to always visible, clicking on it led to a remap from an empty range to calculate the new offset, which triggered a debug assertion in the remap function, because the result is indeterminate. Since in this case there is no need to scroll, we just skip the remap and set the offset to 0 directly. * Closes <#7362> * [x] I have followed the instructions in the PR template
|
this for this PR which closes my issue #7362. I'll be sure to try it out when I get some bandwidth. ❤️ |
Masterchef365
pushed a commit
to Masterchef365/egui
that referenced
this pull request
Apr 3, 2026
…k#7440) If the ScrollArea's contents are smaller than the inner rect, but the scrollbar is set to always visible, clicking on it led to a remap from an empty range to calculate the new offset, which triggered a debug assertion in the remap function, because the result is indeterminate. Since in this case there is no need to scroll, we just skip the remap and set the offset to 0 directly. * Closes <emilk#7362> * [x] I have followed the instructions in the PR template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the ScrollArea's contents are smaller than the inner rect, but the scrollbar is set to always visible, clicking on it led to a remap from an empty range to calculate the new offset, which triggered a debug assertion in the remap function, because the result is indeterminate.
Since in this case there is no need to scroll, we just skip the remap and set the offset to 0 directly.