Skip to content

Enable clippy::iter_over_hash_type lint#7421

Merged
emilk merged 7 commits intomainfrom
emilk/iter_over_hash_type
Aug 6, 2025
Merged

Enable clippy::iter_over_hash_type lint#7421
emilk merged 7 commits intomainfrom
emilk/iter_over_hash_type

Conversation

@emilk
Copy link
Copy Markdown
Owner

@emilk emilk commented Aug 6, 2025

This helped discover a few things that might have been buggy.

@emilk emilk added bug Something is broken egui dev-experience labels Aug 6, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 6, 2025

Preview available at https://egui-pr-preview.github.io/pr/7421-emilkiteroverhashtype
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

Copy link
Copy Markdown
Collaborator

@lucasmerlin lucasmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious if the changes to BtreeMap will have a slight positive performance impact

@emilk
Copy link
Copy Markdown
Owner Author

emilk commented Aug 6, 2025

In most cases the map of viewports has length=1, so I doubt performance will see much impact.

@emilk emilk merged commit 36a4981 into main Aug 6, 2025
47 checks passed
@emilk emilk deleted the emilk/iter_over_hash_type branch August 6, 2025 11:55
Masterchef365 pushed a commit to Masterchef365/egui that referenced this pull request Apr 3, 2026
This helped discover a few things that _might_ have been buggy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something is broken dev-experience egui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants