Merged
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/7385-lucasplugin-trait |
Collaborator
Author
|
Now that I'm done I'm not super convinced that this is better then the previous api. Maybe instead I should just add |
emilk
reviewed
Aug 5, 2025
emilk
reviewed
Aug 7, 2025
Merged
# Conflicts: # crates/egui/src/context.rs
emilk
approved these changes
Sep 4, 2025
# Conflicts: # crates/egui/src/context.rs
mankinskin
pushed a commit
to mankinskin/egui
that referenced
this pull request
Sep 17, 2025
This adds a new `Plugin` trait and new `input_hook` and `output_hook` plugin fns. Having a `Plugin` trait should make it easier to store state in the plugin and improve discoverability of possible plugin hooks. The old `on_begin_pass` and `on_end_pass` have been ported to use the new plugin trait, should we deprecate them?
Masterchef365
pushed a commit
to Masterchef365/egui
that referenced
this pull request
Apr 3, 2026
This adds a new `Plugin` trait and new `input_hook` and `output_hook` plugin fns. Having a `Plugin` trait should make it easier to store state in the plugin and improve discoverability of possible plugin hooks. The old `on_begin_pass` and `on_end_pass` have been ported to use the new plugin trait, should we deprecate them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new
Plugintrait and newinput_hookandoutput_hookplugin fns. Having aPlugintrait should make it easier to store state in the plugin and improve discoverability of possible plugin hooks.The old
on_begin_passandon_end_passhave been ported to use the new plugin trait, should we deprecate them?