Merged
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/7383-lucasfix-manual-popup-close |
emilk
reviewed
Aug 5, 2025
|
|
||
| let closed_by_click = match close_behavior { | ||
| PopupCloseBehavior::CloseOnClick => widget_clicked_elsewhere, | ||
| PopupCloseBehavior::CloseOnClick => close_click, |
Owner
There was a problem hiding this comment.
Shouldn't this close on any click?
Suggested change
| PopupCloseBehavior::CloseOnClick => close_click, | |
| PopupCloseBehavior::CloseOnClick => ctx.input(|i| i.pointer.any_click()), |
Collaborator
Author
There was a problem hiding this comment.
We need to check if the click was the click that was used to open the popup, so we don't immediately close it again.
Previously we did this via the widget_clicked_elsewhere, which is also what we did in the old popup api. But I just realized this also won't work when using Popup::new so I came up with a better check. Now, on click, the popup will only close when it was already open last frame (by checking if a reasponse exists via ctx.read_response).
emilk
approved these changes
Aug 7, 2025
|
|
||
| let closed_by_click = match close_behavior { | ||
| PopupCloseBehavior::CloseOnClick => widget_clicked_elsewhere, | ||
| PopupCloseBehavior::CloseOnClick => close_click, |
emilk
pushed a commit
that referenced
this pull request
Aug 15, 2025
Fixes manually created popups (via `Popup::new`) not closing, since
widget_clicked_elsewhere was always false.
This example would never close:
```rs
let mut open = true;
eframe::run_simple_native("My egui App", options, move |ctx, _frame| {
egui::CentralPanel::default().show(ctx, |ui| {
let response = egui::Popup::new(
Id::new("popup"),
ctx.clone(),
PopupAnchor::Position(Pos2::new(10.0, 10.0)),
LayerId::new(Order::Foreground, Id::new("popup")),
)
.open(open)
.show(|ui| {
ui.label("This is a popup!");
ui.label("You can put anything in here.");
});
if let Some(response) = response {
if response.response.should_close() {
open = false;
}
}
});
})
```
I also noticed that the Color submenu in the popups example had a double
arrow (must have been broken in the atoms PR):
<img width="248" height="110" alt="Screenshot 2025-08-07 at 13 42 28"
src="https://github.com/user-attachments/assets/a4e0c267-ae71-4b2c-a1f0-f53f9662d026"
/>
Also fixed this in the PR.
Masterchef365
pushed a commit
to Masterchef365/egui
that referenced
this pull request
Apr 3, 2026
Fixes manually created popups (via `Popup::new`) not closing, since
widget_clicked_elsewhere was always false.
This example would never close:
```rs
let mut open = true;
eframe::run_simple_native("My egui App", options, move |ctx, _frame| {
egui::CentralPanel::default().show(ctx, |ui| {
let response = egui::Popup::new(
Id::new("popup"),
ctx.clone(),
PopupAnchor::Position(Pos2::new(10.0, 10.0)),
LayerId::new(Order::Foreground, Id::new("popup")),
)
.open(open)
.show(|ui| {
ui.label("This is a popup!");
ui.label("You can put anything in here.");
});
if let Some(response) = response {
if response.response.should_close() {
open = false;
}
}
});
})
```
I also noticed that the Color submenu in the popups example had a double
arrow (must have been broken in the atoms PR):
<img width="248" height="110" alt="Screenshot 2025-08-07 at 13 42 28"
src="https://github.com/user-attachments/assets/a4e0c267-ae71-4b2c-a1f0-f53f9662d026"
/>
Also fixed this in the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes manually created popups (via
Popup::new) not closing, since widget_clicked_elsewhere was always false.This example would never close:
I also noticed that the Color submenu in the popups example had a double arrow (must have been broken in the atoms PR):
Also fixed this in the PR.