Allow customizing fallback font in AtomLayout#7382
Merged
lucasmerlin merged 2 commits intolucas/fix-rich-text-font-fallbackfrom Aug 7, 2025
Merged
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/7382-lucasatom-layout-customize-fallback-font |
…ut-customize-fallback-font
emilk
approved these changes
Aug 5, 2025
| layout: AtomLayout::new(atoms.into_atoms()).sense(Sense::click()), | ||
| layout: AtomLayout::new(atoms.into_atoms()) | ||
| .sense(Sense::click()) | ||
| .fallback_font(TextStyle::Button), |
Owner
There was a problem hiding this comment.
Maybe this should be called "default_font" instead? I dunno
Collaborator
Author
There was a problem hiding this comment.
It's also called fallback font in WidgetText so I think we should update it there as well for consistency. I'll open a PR for that
lucasmerlin
merged commit d61d36d
into
lucas/fix-rich-text-font-fallback
48 of 49 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WidgetText::Textignoring fallback font and overrides #7361 (this pr requires the clone derive introduced there)Before it was hard coded to TextStyle::Button, but it should be customizable.