Fix leading_space sometimes being ignored during paragraph splitting#7031
Merged
emilk merged 2 commits intoemilk:mainfrom May 8, 2025
Merged
Fix leading_space sometimes being ignored during paragraph splitting#7031emilk merged 2 commits intoemilk:mainfrom
leading_space sometimes being ignored during paragraph splitting#7031emilk merged 2 commits intoemilk:mainfrom
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/7031-fix-leading-space |
emilk
approved these changes
May 8, 2025
Owner
emilk
left a comment
emilk
left a comment
There was a problem hiding this comment.
Good catch!
We should add a test case for this at the end of the file too (just set leading_space in one of the test cases)
This allows it to catch issues with `leading_space` if they only occur after the first paragraph, which is a likely case.
Contributor
Author
|
I swapped the |
emilk
approved these changes
May 8, 2025
darkwater
pushed a commit
to darkwater/egui
that referenced
this pull request
Aug 24, 2025
emilk#7031) Fixes a regression introduced in emilk#5411 (possibly emilk@d74bee5) that breaks `leading_space` handling. I think this is what the condition should be but I haven't touched this code in a while.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in #5411 (possibly d74bee5) that breaks
leading_spacehandling.I think this is what the condition should be but I haven't touched this code in a while.