Support SVG Text Rendering in egui_extras#5979
Merged
emilk merged 3 commits intoemilk:masterfrom Apr 14, 2025
Merged
Conversation
…dering by loading system fonts
emilk
approved these changes
Apr 13, 2025
|
Preview available at https://egui-pr-preview.github.io/pr/5979-master |
Owner
|
Also needs |
emilk
changed the title
darkwater
pushed a commit
to darkwater/egui
that referenced
this pull request
Aug 24, 2025
**Added** * Create `svg_text` feature flag to support text rendering & loading of system fonts. **Changed** * Updates `resvg` to `0.45`. * Adds `usvg::Options` field to the `SvgLoader` structure. * Change function signatures to support passing `usvg::Options` to downstream `load_svg_bytes_with_size`. **Additional Info** * I used this PR as a reference: emilk#4659. @xNWP can you see if this adequately resolves your concern from your original PR? * Closes emilk#5977 (we may want to open another issue for my other thoughts in this issue) * Also, I would like to thank @xNWP and their original PR for being a good reference for this one. * [x] I have followed the instructions in the PR template
|
I totally missed this, oops! But thanks for cleaning this up and finishing it, looks good 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
svg_textfeature flag to support text rendering & loading of system fonts.Changed
resvgto0.45.usvg::Optionsfield to theSvgLoaderstructure.usvg::Optionsto downstreamload_svg_bytes_with_size.Additional Info
svg_text#4659. @xNWP can you see if this adequately resolves your concern from your original PR?egui_extras#5977 (we may want to open another issue for my other thoughts in this issue)