Fix modifiers not working in kittest#5693
Merged
lucasmerlin merged 4 commits intomasterfrom Feb 10, 2025
Merged
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/5693-fix-kittest-modifiers |
emilk
approved these changes
Feb 7, 2025
Co-authored-by: Emil Ernerfeldt <[email protected]>
lucasmerlin
added a commit
that referenced
this pull request
Mar 3, 2025
* Closes <#5690> * [x] I have followed the instructions in the PR template It still isn't ideal, since you have to remember to call key_up on a separate frame. --------- Co-authored-by: Emil Ernerfeldt <[email protected]> (cherry picked from commit 1c6e7b1)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It still isn't ideal, since you have to remember to call key_up on a separate frame.