Support on hover tooltip that is noninteractable even with interactable content#5543
Conversation
PPakalns
commented
Dec 29, 2024
- Closes Noninteractive tooltip with any content (on_hover_ui) #5519
- I have followed the instructions in the PR template
|
Tested in real use case. Greatly reduces flickering for "preview" tooltips that may contain interactable widgets. Use case: "Preview" of the page/window that will be opened if the button is pressed. |
|
Preview available at https://egui-pr-preview.github.io/pr/5543-noninteractivetooltip |
|
@emilk I ran into a related problem: rerun-io/rerun#8568 It seems like the current logic in In the case of the Rerun graph view, we can simply call |
942690e to
ebbf493
Compare
|
Resolved conflicts. |
ebbf493 to
37240f1
Compare
|
Updated against newest master to rerun checks that failed due to incorrectly configured github pipeline action. |
emilk
left a comment
There was a problem hiding this comment.
I appreciate the need for this functionality, but I think it's time to make a builder for tooltips so that we don't get this combinatorial explosion of tooltip methods
@emilk To make sure that I decide the right design for this, feel free to correct me: Currently we have methods: And this PR wants to add parameter to configure if hover (tooltip) ui is interactable. I could replace these methods with one simple method: Where HoverBuilder has configurable options:
Does this design seems OK? |
37240f1 to
8a9c9a0
Compare
|
PR is ready for review! Refactored code. Removed duplicated |
lucasmerlin
left a comment
There was a problem hiding this comment.
Thanks! I guess it's not very convenient to use this, but since it handles an edge case it should be fine.