Make sure to call raw_input_hook on web
#4646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owen Diehl <[email protected]>
emilk
approved these changes
Jun 18, 2024
emilk
added
web
emilk
changed the title
raw_input_hook on web
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
## What's new * Extends @varphone's excellent `raw_input_hook` idea from emilk#4008 to `web/app_runner`. ## Details Debugging this locally after my app's `raw_input_hook` wasn't being called, I realized it's not in the code path of eframe's web runner, only the native integration. Below is a toy example running on the web. https://github.com/emilk/egui/assets/8173478/d470b7e6-d393-4ead-9745-3aafc72ae6bc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
raw_input_hookidea from eframe: AddedApp::raw_input_hookallows for the manipulation or filtering of raw input events #4008 toweb/app_runner.Details
Debugging this locally after my app's
raw_input_hookwasn't being called, I realized it's not in the code path of eframe's web runner, only the native integration. Below is a toy example running on the web.Screen.Recording.2024-06-09.at.7.57.07.PM.mov