GIF support #4620
GIF support #4620
Conversation
|
Could add |
emilk
left a comment
emilk
left a comment
There was a problem hiding this comment.
This is looking very promising! A a great test gif too :)
|
@emilk every requested change is implemented. I didn't test the file_loader, but it should behave the exactly like the ehttp loader which works. |
Co-authored-by: Emil Ernerfeldt <[email protected]>
|
@emilk ?? |
emilk
left a comment
emilk
left a comment
There was a problem hiding this comment.
Veery close now - just a few cleanups and we should be good to go
|
btw, as I mention in the PR template, opening a PR from your |
Co-authored-by: Emil Ernerfeldt <[email protected]>
|
@emilk Im sorry. I will keep that in mind for the next pull request |
emilk
left a comment
emilk
left a comment
There was a problem hiding this comment.
Awesome work - this is really cool!
| fn update(&mut self, ctx: &egui::Context, _frame: &mut eframe::Frame) { | ||
| egui::CentralPanel::default().show(ctx, |ui| { | ||
| egui::ScrollArea::both().show(ui, |ui| { | ||
| ui.image(egui::include_image!("ferris.gif")); |
There was a problem hiding this comment.
It's super cool that this Just Works™️
|
should be ready to merge now |
|
Thanks for going through all the review rounds on this! |
* Previous PR: emilk#3951 * Closes emilk#4489 --------- Co-authored-by: Emil Ernerfeldt <[email protected]>
3 participants
If you use
egui_extrasyou need to add thegiffeature flag to it. Then adding a .gif to egui is as easy as