Support returning errors when creating the app #4565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The closure passed to `eframe::run_native` now returns a `Result`, allowing you to return an error during app creation, which will be returned to the caller of `run_native`.
emilk
force-pushed
the
emilk/fallible-app-creation
branch
from
b90a0c9 to
2c921d7
Compare
emilk
added
feature
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
The closure passed to `eframe::run_native` now returns a `Result`, allowing you to return an error during app creation, which will be returned to the caller of `run_native`. This means you need to wrap your `Box::new(MyApp::new(…))` in an `Ok(…)`. * Closes emilk#4474
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
* Follow-up to emilk#4565
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The closure passed to
eframe::run_nativenow returns aResult, allowing you to return an error during app creation, which will be returned to the caller ofrun_native.This means you need to wrap your
Box::new(MyApp::new(…))in anOk(…).