Make scroll_to_* animations configurable
#4305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmerlin
force-pushed
the
make-scroll-animation-configurable
branch
2 times, most recently
from
6c0800a to
c89f542
Compare
lucasmerlin
force-pushed
the
make-scroll-animation-configurable
branch
2 times, most recently
from
7bc6730 to
8c36ee7
Compare
lucasmerlin
force-pushed
the
make-scroll-animation-configurable
branch
from
8c36ee7 to
65b0676
Compare
Collaborator
Author
|
@emilk Can you have a look at this one? I think it's a useful addition and it even removes one of your TODOs! |
emilk
reviewed
Jul 4, 2024
lucasmerlin
force-pushed
the
make-scroll-animation-configurable
branch
2 times, most recently
from
5a93a1f to
d173e54
Compare
lucasmerlin
force-pushed
the
make-scroll-animation-configurable
branch
from
d173e54 to
902817e
Compare
emilk
reviewed
Jul 5, 2024
lucasmerlin
commented
Jul 5, 2024
emilk
reviewed
Jul 15, 2024
lucasmerlin
force-pushed
the
make-scroll-animation-configurable
branch
from
1e4e873 to
b393b71
Compare
emilk
changed the title
scroll_to_* animations configurable
486c
pushed a commit
to 486c/egui
that referenced
this pull request
Oct 9, 2024
<!-- Please read the "Making a PR" section of [`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md) before opening a Pull Request! * Keep your PR:s small and focused. * The PR title is what ends up in the changelog, so make it descriptive! * If applicable, add a screenshot or gif. * If it is a non-trivial addition, consider adding a demo for it to `egui_demo_lib`, or a new example. * Do NOT open PR:s from your `master` branch, as that makes it hard for maintainers to add commits to your PR. * Remember to run `cargo fmt` and `cargo cranky`. * Open the PR as a draft until you have self-reviewed it and run `./scripts/check.sh`. * When you have addressed a PR comment, mark it as resolved. Please be patient! I will review your PR, but my time is limited! --> * Closes emilk#4295 I based this on emilk#4303, I'll rebase once that one gets merged.
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
<!-- Please read the "Making a PR" section of [`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md) before opening a Pull Request! * Keep your PR:s small and focused. * The PR title is what ends up in the changelog, so make it descriptive! * If applicable, add a screenshot or gif. * If it is a non-trivial addition, consider adding a demo for it to `egui_demo_lib`, or a new example. * Do NOT open PR:s from your `master` branch, as that makes it hard for maintainers to add commits to your PR. * Remember to run `cargo fmt` and `cargo cranky`. * Open the PR as a draft until you have self-reviewed it and run `./scripts/check.sh`. * When you have addressed a PR comment, mark it as resolved. Please be patient! I will review your PR, but my time is limited! --> * Closes emilk#4295 I based this on emilk#4303, I'll rebase once that one gets merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I based this on #4303, I'll rebase once that one gets merged.