Fix egui_extras::Table scrolling bug
#3690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
changed the title
egui_extras::Tableegui_extras::Table scrolling bug
emilk
approved these changes
Dec 7, 2023
emilk
added a commit
that referenced
this pull request
Dec 8, 2023
Includes: * #3690 --------- Co-authored-by: Antoine Beyeler <[email protected]>
4 tasks
emilk
added a commit
to rerun-io/rerun
that referenced
this pull request
Dec 10, 2023
### What * Contains emilk/egui#3690 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Full build: [app.rerun.io](https://app.rerun.io/pr/4461/index.html) * Partial build: [app.rerun.io](https://app.rerun.io/pr/4461/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) - Useful for quick testing when changes do not affect examples in any way * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4461) - [Docs preview](https://rerun.io/preview/bfe0b472532fc19fb3dc9da1ba544099ee7f24b6/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/bfe0b472532fc19fb3dc9da1ba544099ee7f24b6/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
egui_extras::Tablenow uses the clip rectangle to decide which rows to draw when usingTableBody::rows().Table::rowseven when the table has no scroll area #3682egui_extras::Tabledoesn't behave properly when inside of aScrollArea#3670