Fix keyboard support in DragValue
#2342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwcampbell
changed the title
DragValueDragValue
emilk
requested changes
Nov 24, 2022
Owner
emilk
left a comment
emilk
left a comment
There was a problem hiding this comment.
Looks good, but I would like to keep the behavior of pressing right and left!
Co-authored-by: Emil Ernerfeldt <[email protected]>
emilk
approved these changes
Nov 29, 2022
Owner
|
Thanks! |
emilk
added a commit
that referenced
this pull request
Dec 2, 2022
* Enable incrementing and decrementing `DragValue` with the keyboard * As soon as a DragValue is focused, render it in edit mode * Simpler, more reliable approach to managing the drag value's edit string * Add changelog entry * Update doc comment Co-authored-by: Emil Ernerfeldt <[email protected]> * Add comment explaining why we don't listen for left/right arrow Co-authored-by: Emil Ernerfeldt <[email protected]>
JohannesProgrammiert
pushed a commit
to JohannesProgrammiert/egui
that referenced
this pull request
Jan 21, 2023
* Enable incrementing and decrementing `DragValue` with the keyboard * As soon as a DragValue is focused, render it in edit mode * Simpler, more reliable approach to managing the drag value's edit string * Add changelog entry * Update doc comment Co-authored-by: Emil Ernerfeldt <[email protected]> * Add comment explaining why we don't listen for left/right arrow Co-authored-by: Emil Ernerfeldt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2341.