Repository navigation
Faster Angle initialisation. - #13
Merged
embray merged 1 commit intoFeb 2, 2015
Merged
Conversation
Owner
|
Oh I see, this is a PR against my PR (I was confused for a moment). Looks like you had roughly the same idea here, but I'm sure your patch is cleaner. I'll see if I can incorporate it. |
Owner
|
@mhvk Thanks, I fully incorporated your patch on top of mine, as it seemed to squeeze out even a little more performance than mine. We've made the test case from astropy#3323 nearly 20 times faster now :) |
Author
|
Great! |
embray
pushed a commit
that referenced
this pull request
Jan 19, 2016
Lazyproperty for cache / easier scale setting in __add__, __sub__
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@embray - here is my speed-up work. As I was working in parallel, it conflicts with your latest commit (the end-of-the-init part of which I include here; the earlier part could be removed altogether).